Quoting Ville Syrj�l� ([EMAIL PROTECTED]): > > > --- DirectFB/src/core/fbdev/fbdev.c 2003-03-24 23:01:55.000000000 +0200 > > > +++ DirectFB/src/core/fbdev/fbdev.c 2003-04-01 18:09:46.000000000 +0300 > > > @@ -965,7 +965,7 @@ > > > DFBResult ret; > > > CoreSurface *surface = dfb_layer_surface( layer ); > > > > > > - if ((flags & DSFLIP_WAITFORSYNC) && !dfb_config->pollvsync_after) > > > + if ((flags & DSFLIP_WAIT) && !dfb_config->pollvsync_after) > > > dfb_layer_wait_vsync( layer ); > > > > > > ret = dfb_fbdev_pan( surface->back_buffer->video.offset / > > > @@ -973,7 +973,7 @@ > > > if (ret) > > > return ret; > > > > > > - if ((flags & DSFLIP_WAITFORSYNC) && dfb_config->pollvsync_after) > > > + if ((flags & DSFLIP_WAIT) && dfb_config->pollvsync_after) > > > dfb_layer_wait_vsync( layer ); > > > > Implies DSFLIP_ONSYNC if DSFLIP_WAIT is used, but is ok for now. > > I take it pollvsync_after should be handled as if it was a property of the > hardware? Too bad fbdev doesn't provide this information. > > How about this code? > > if (((flags & DSFLIP_WAITFORSYNC) == DSFLIP_WAITFORSYNC) && > !dfb_config->pollvsync_after) > dfb_layer_wait_vsync( layer ); > > ret = dfb_fbdev_pan( surface->back_buffer->video.offset / > surface->back_buffer->video.pitch ); > if (ret) > return ret; > > if ((flags & DSFLIP_WAIT) && > (dfb_config->pollvsync_after || !(flags & DSFLIP_ONSYNC))) > dfb_layer_wait_vsync( layer ); >
Looks good and is still compatible to the old behaviour. > > These should honor DSFLIP_ONSYNC, currently they imply it. > > So it should be something like this? > > if ((flags & DSFLIP_WAITFORSYNC) == DSFLIP_WAITFORSYNC) > dfb_layer_wait_vsync( layer ); > > dfb_back_to_front_copy(); > > if ((flags & DSFLIP_WAITFORSYNC) == DSFLIP_WAIT) > dfb_layer_wait_vsync( layer ); Yes. But DSFLIP_ONSYNC only is unsupported (impossible) :-) -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | "------------------------------------------" Convergence GmbH -- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe directfb-dev" as subject.
