Hi,

for colorkeying did not work with the following onboard graphic:
00:02.0 VGA compatible controller: Intel Corporation 82852/855GM Integrated 
Graphics Device (rev 02)

Softdevice OSD was only shown in that area where no video was drawn.
Base thread of this discussion (in german) is here:
http://www.vdr-portal.de/board/thread.php?threadid=54640

Allthough it is still unresolved for original reporter, the attached patch 
solves the issue for me.
Changes are similar to code from Xorg:
http://webcvs.freedesktop.org/xorg/driver/xf86-video-i810/src/i830_video.c?annotate=1.22
line 508 .


-- 
Stefan Lucke
Index: i830_overlay.c
===================================================================
RCS file: /cvs/directfb/DirectFB/gfxdrivers/i830/i830_overlay.c,v
retrieving revision 1.5
diff -U 3 -r1.5 i830_overlay.c
--- i830_overlay.c	1 May 2006 18:51:52 -0000	1.5
+++ i830_overlay.c	13 Sep 2006 19:18:57 -0000
@@ -771,8 +771,20 @@
      regs->DCLRKV = dfb_color_to_pixel( primary_format,
                                         config->dst_key.r, config->dst_key.g, config->dst_key.b );
 
-     regs->DCLRKM = (1 << DFB_COLOR_BITS_PER_PIXEL( primary_format )) - 1;
-
+     switch (DFB_COLOR_BITS_PER_PIXEL( primary_format )) {
+          case 8:
+               regs->DCLRKM = 0xffffff;
+               break;
+          case 15:
+               regs->DCLRKM = 0x070707;
+               break;
+          case 16:
+               regs->DCLRKM = 0x070307;
+               break;
+          default:
+               regs->DCLRKM = 0;
+               break;
+     }
      if (config->options & DLOP_DST_COLORKEY)
           regs->DCLRKM |= DEST_KEY_ENABLE;
 
_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev

Reply via email to