I remember of Simon's patch: it was me who applied to gnome svn both in trunk and gtk-2-10 branches. I also remember of simon's seconds toughts on the patch, but we eventually decided to commit first version of simon's patch with additional dfb version checking from me. The code currently in gnome svn proved to be effecctive in the graphical debian-instaler, where we recently switched to dfb 1.0.1 (we sasved up many megs of memory during thanks to simons patch) I'm available for committing further patches to the code in gnome svn, provided i'm given the patch :)
regards Attilio Mike Emmel wrote: > Not sure what you mean about not correctly send me a path that can be > applied to the current GTK svn and I'll look at it. > Or add a new patch to the bug. > If I recall a small amount of refactoring was done to clean the code > up and I think take care of some null checks its been a long time,. > > Now other changes could have since broken the patch who knows. > > I don't know about this second patch it should be done as a new bug. > He probably added it to a closed bug. > > > > On 10/20/07, Binary Chen <[EMAIL PROTECTED]> wrote: >> Hi, >> >> I just read the memory leak bug patched by Simon.Lanzmich, Simon >> submitted two emails, the first and the second differs, the latter is: >> >> http://www.mail-archive.com/[email protected]/msg06425.html >> >> But I took a look in gtk+'s SVN tree, find the applied patch is the >> first one, which still cause problem on Directfb-1.0.0. Because there is >> a lost reference in Simon's graph, that is in dfb_window_create(), the >> dfb_wm_add_window() will also add one reference to CoreWindow(in unique >> window manager). The reference is removed by dfb_wm_remove_window() >> which is called by IDirectFBWindow_Destroy(). >> >> So Simon's second patch handles this problem, but seems not applied >> correctly? >> >> The URL for the SVN is: >> >> http://svn.gnome.org/viewvc/gtk% >> 2B/trunk/gdk/directfb/gdkwindow-directfb.c?r1=18004&r2=18459 >> >> Thanks. >> Bin >> >> >> _______________________________________________ >> directfb-dev mailing list >> [email protected] >> http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev >> > > _______________________________________________ > directfb-dev mailing list > [email protected] > http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev > _______________________________________________ directfb-dev mailing list [email protected] http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
