Author: olamy
Date: Tue Feb 21 14:32:16 2012
New Revision: 1291808

URL: http://svn.apache.org/viewvc?rev=1291808&view=rev
Log:
[DIRECTMEMORY-61] add DirectMemoryCacheRequest constructor with key to ease 
some api usage.

Modified:
    
incubator/directmemory/trunk/server/directmemory-server-commons/src/main/java/org/apache/directmemory/server/commons/DirectMemoryCacheRequest.java
    
incubator/directmemory/trunk/server/directmemory-server/src/test/java/org/apache/directmemory/server/services/ServletWithClientTest.java

Modified: 
incubator/directmemory/trunk/server/directmemory-server-commons/src/main/java/org/apache/directmemory/server/commons/DirectMemoryCacheRequest.java
URL: 
http://svn.apache.org/viewvc/incubator/directmemory/trunk/server/directmemory-server-commons/src/main/java/org/apache/directmemory/server/commons/DirectMemoryCacheRequest.java?rev=1291808&r1=1291807&r2=1291808&view=diff
==============================================================================
--- 
incubator/directmemory/trunk/server/directmemory-server-commons/src/main/java/org/apache/directmemory/server/commons/DirectMemoryCacheRequest.java
 (original)
+++ 
incubator/directmemory/trunk/server/directmemory-server-commons/src/main/java/org/apache/directmemory/server/commons/DirectMemoryCacheRequest.java
 Tue Feb 21 14:32:16 2012
@@ -48,6 +48,16 @@ public class DirectMemoryCacheRequest<V>
      */
     private boolean deleteRequest = false;
 
+    public DirectMemoryCacheRequest( )
+    {
+        // no op
+    }
+
+    public DirectMemoryCacheRequest( String key )
+    {
+        this.setKey( key );
+    }
+
     public boolean isUpdate()
     {
         return update;

Modified: 
incubator/directmemory/trunk/server/directmemory-server/src/test/java/org/apache/directmemory/server/services/ServletWithClientTest.java
URL: 
http://svn.apache.org/viewvc/incubator/directmemory/trunk/server/directmemory-server/src/test/java/org/apache/directmemory/server/services/ServletWithClientTest.java?rev=1291808&r1=1291807&r2=1291808&view=diff
==============================================================================
--- 
incubator/directmemory/trunk/server/directmemory-server/src/test/java/org/apache/directmemory/server/services/ServletWithClientTest.java
 (original)
+++ 
incubator/directmemory/trunk/server/directmemory-server/src/test/java/org/apache/directmemory/server/services/ServletWithClientTest.java
 Tue Feb 21 14:32:16 2012
@@ -100,16 +100,14 @@ public class ServletWithClientTest
         // START SNIPPET: client-put
 
         client.put(
-            new DirectMemoryCacheRequest<Wine>()
-                .setObject( bordeaux )
-                .setKey( "bordeaux" ) );
+            new DirectMemoryCacheRequest<Wine>( "bordeaux" )
+                .setObject( bordeaux ) );
 
         // END SNIPPET: client-put
 
         // START SNIPPET: client-get
         DirectMemoryCacheRequest rq =
-            new DirectMemoryCacheRequest()
-                .setKey( "bordeaux" )
+            new DirectMemoryCacheRequest( "bordeaux" )
                 .setObjectClass( Wine.class );
 
         DirectMemoryCacheResponse<Wine> response = client.retrieve( rq );
@@ -127,7 +125,7 @@ public class ServletWithClientTest
     {
 
         DirectMemoryCacheResponse<Wine> response = client.retrieve(
-            new DirectMemoryCacheRequest().setKey( "Italian wine better than 
French" )
+            new DirectMemoryCacheRequest( "Italian wine better than French" )
                 .setObjectClass( Wine.class ) );
 
         // due to the key used the server should response BAD Request but it 
says not found
@@ -146,8 +144,7 @@ public class ServletWithClientTest
                         .setKey( "bordeaux" ) );
 
         DirectMemoryCacheResponse<Wine> response = client.retrieve(
-            new DirectMemoryCacheRequest()
-                .setKey( "bordeaux" )
+            new DirectMemoryCacheRequest( "bordeaux" )
                 .setObjectClass( Wine.class ) );
 
         assertTrue( response.isFound() );
@@ -157,13 +154,12 @@ public class ServletWithClientTest
 
         // START SNIPPET: client-delete
         DirectMemoryCacheResponse deleteResponse =
-            client.delete( new DirectMemoryCacheRequest<Wine>().setKey( 
"bordeaux" ) );
+            client.delete( new DirectMemoryCacheRequest<Wine>( "bordeaux" ) );
         assertTrue( deleteResponse.isDeleted() );
 
         // END SNIPPET: client-delete
 
-        response = client.retrieve( new DirectMemoryCacheRequest()
-                                        .setKey( "bordeaux" )
+        response = client.retrieve( new DirectMemoryCacheRequest( "bordeaux" )
                                         .setObjectClass( Wine.class ) );
 
         assertFalse( response.isFound() );
@@ -176,7 +172,7 @@ public class ServletWithClientTest
         throws Exception
     {
         DirectMemoryCacheResponse deleteResponse =
-            client.delete( new DirectMemoryCacheRequest<Wine>().setKey( 
"fofoofofof" ) );
+            client.delete( new DirectMemoryCacheRequest<Wine>( "fofoofofof" ) 
);
         assertFalse( deleteResponse.isDeleted() );
     }
 }


Reply via email to