Merci Benoit :) I'll wait until tonight so someone else will have the chance to take a look at it, then I'll push it.
Thanks a lot everybody for review! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Feb 23, 2012 at 5:00 PM, Benoit Perroud <[email protected]> wrote: > Hi All, > > I had a chance to go through the pull, it's a big +1. > > Thanks Simone ! > > Benoit. > > > > 2012/2/23 Tommaso Teofili <[email protected]>: >> I'm also offline for some days, +1 for pushing it in :) >> Tommaso >> >> 2012/2/23 Olivier Lamy <[email protected]> >> >>> Sorry I'm a bit off until saturday to have a look. >>> So push it :-) >>> >>> -- >>> Olivier >>> Send from a vt100 phone terminal >>> Le 23 févr. 2012 13:19, "Simone Tripodi" <[email protected]> a >>> écrit : >>> >>> > does anybody have feedbacks to provide? If no objection will be shown, >>> > I'll assume lazy consensus... >>> > >>> > TIA, >>> > -Simo >>> > >>> > http://people.apache.org/~simonetripodi/ >>> > http://simonetripodi.livejournal.com/ >>> > http://twitter.com/simonetripodi >>> > http://www.99soft.org/ >>> > >>> > >>> > >>> > On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache <[email protected]> >>> > wrote: >>> > > GitHub user simonetripodi opened the pull request at >>> > > https://github.com/apache/directmemory/pull/2 >>> > > >>> > > ---- >>> > > [DIRECTMEMORY-43] Cache should allow key objects instead of plain >>> string >>> > > >>> > > This is my proposal to change the DM signature from <String, Object> to >>> > <K, V>. >>> > > >>> > > It contains some signatures modification. >>> > > >>> > > Please review! >>> > > ---- >>> > > >>> > > You can merge this pull request into a Git repository by running >>> > > $ git pull https://github.com/simonetripodi/directmemory trunk >>> > > >>> > > Alternatively you can review and apply these changes as the patch at >>> > > https://github.com/apache/directmemory/pull/2.patch >>> > >>> > > > > -- > sent from my Nokia 3210
