Thanks, haha yes I need to sort test cases out, especially as I think element is how ehache maintains tti and ttl on the elements, but I need to write test cases and fix things that aren't working. Also just a side note where/how do we document up things like this? I noticed the default wiki isn't started at all yet are we doing something different?
Sent from my iPhone On 25 Feb 2012, at 10:19, "Benoit Perroud (Commented) (JIRA)" <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/DIRECTMEMORY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216394#comment-13216394 > ] > > Benoit Perroud commented on DIRECTMEMORY-60: > -------------------------------------------- > > Thanks for your contribution ! > I had a chance to go through you patch. It's integrated rev 1293567. I just > reworked a few small pieces : > - Code formatting > - Adding ASF Licences headers > - Remove code duplication in > MemoryManagerServiceWithAllocationPolicyEhcacheImpl.java to throw an > exception intead of returing null > - Assert.fail instead of Assert.assertTrue(false) :) > > I really like the trick to have a class called > net.sf.ehcache.store.offheap.OffHeapStore to enable offHeap in ehcache :) > Multi-layered cache : here we are ! > > Anyway, this contribution will be a real big plus for DM. Thanks a lot ! > >> EHCache Integration >> ------------------- >> >> Key: DIRECTMEMORY-60 >> URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-60 >> Project: Apache DirectMemory >> Issue Type: New Feature >> Reporter: Michael André Pearce >> Priority: Minor >> Labels: EHCache, Integration >> Attachments: DIRECTMEMORY-60.tidy.zip, DIRECTMEMORY-60.zip, >> directmemory-ehcache.zip >> >> >> Integrate DirectMemory to be used with EHCache. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > >
