oraluben commented on code in PR #300: URL: https://github.com/apache/tvm-ffi/pull/300#discussion_r2633771993
########## cmake/Utils/EmbedCubin.cmake: ########## @@ -15,205 +15,163 @@ # specific language governing permissions and limitations # under the License. +# Do not let cmake to link cudart. +set(CMAKE_CUDA_RUNTIME_LIBRARY None) Review Comment: I agree with most of your points: we shouldn’t change the default configuration, and we should document the issues around `CMAKE_CUDA_RUNTIME_LIBRARY`. But I’d like to discuss one additional possibility: if `CMAKE_CUDA_RUNTIME_LIBRARY` is not set, we set it to `shared`. In nearly all cases (maybe all), static linking is not what users actually want. For users unaware of this setting, defaulting to `shared` has no downside and may help in some cases. If the user has already set it, we won’t override their choice. We can also document that if users want to use only the driver API, they should explicitly set it to `None` and link against `libcuda` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
