gemini-code-assist[bot] commented on PR #18636: URL: https://github.com/apache/tvm/pull/18636#issuecomment-3709350163
## Summary of Changes Hello @kimm240, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the `fuseReductionEpilogue` mechanism to support arbitrary epilogue expressions, moving away from a rigid pattern-matching approach. By storing the entire epilogue expression and introducing generalized transformation logic for both initialization and updates, the system becomes more flexible and extensible, capable of handling a wider range of post-reduction operations without needing explicit pattern definitions. This change improves the generality and maintainability of the code while ensuring backward compatibility with existing tests. ### Highlights * **Pattern Matching Removal**: The previous pattern-matching approach for epilogue types (Bias, BiasReLU, Clipping) has been entirely removed. This includes the deletion of the `EpilogueType` enum and the `AnalyzeEpiloguePattern()` function, simplifying the logic by directly processing the entire epilogue expression. * **Store Entire Epilogue Expression**: The `ReductionEpilogueFuser` now stores the complete epilogue expression in `epilogue_expression_` and identifies the specific `reduction_buffer_load_` within it. This change eliminates the need for pattern-specific member variables and allows for a more generalized handling of post-reduction operations. * **Generalized Init Transformation**: A new `InitSubstituter` class has been introduced to handle the initialization of the fused reduction block. It replaces the reduction buffer load within the full epilogue expression with an identity element (e.g., 0 for addition-based reductions), allowing for a generalized calculation of the initial value, which is then simplified. * **Generalized Update Transformation**: The update logic now uses a `GeneralizedEpilogueApplier` within an `UpdateSubstituter`. This applier intelligently replaces the reduction buffer load with the reduction update. It also includes logic to automatically detect and remove bias addends if the reduction buffer load's parent is an `Add` node and the other operand is not a reduction buffer, supporting arbitrary activation functions. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
