gemini-code-assist[bot] commented on code in PR #386:
URL: https://github.com/apache/tvm-ffi/pull/386#discussion_r2665683055
##########
include/tvm/ffi/string.h:
##########
@@ -647,7 +647,7 @@ class String {
* \param count The length of the substring (default: until end of string)
* \return A string containing the substring
*/
- String substr(size_t pos = 0, size_t count = size_t(-1)) const {
+ String substr(size_t pos = 0, size_t count = static_cast<size_t>(-1)) const {
Review Comment:
For consistency with `std::string` and other methods in this class (like
`find`), it would be better to use the `npos` static member for the default
value of `count`.
```c
String substr(size_t pos = 0, size_t count = npos) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
