gemini-code-assist[bot] commented on code in PR #389:
URL: https://github.com/apache/tvm-ffi/pull/389#discussion_r2667101402
##########
.pre-commit-config.yaml:
##########
@@ -85,6 +85,14 @@ repos:
rev: "v21.1.7"
hooks:
- id: clang-format
+ - repo: local
+ hooks:
+ - id: clang-tidy
+ name: clang-tidy
+ entry: uv run --no-project --with "clang-tidy==21.1.1" python
tests/lint/clang_tidy_precommit.py --build-dir=build-pre-commit
Review Comment:
I've noticed a couple of potential improvements for the `entry` command:
1. **Invalid package version**: The version `21.1.1` for the `clang-tidy`
PyPI package appears to be incorrect, as this version is not available on PyPI.
This will cause the hook installation to fail. I've suggested using a recent
valid version, `18.1.8`, but you should confirm which version is most
appropriate for your project, ideally aligning it with the `clang-format`
version.
2. **Redundant argument**: The `--build-dir=build-pre-commit` argument is
redundant. The `tests/lint/clang_tidy_precommit.py` script already uses
`build-pre-commit` as the default value for this argument. Removing it makes
the configuration cleaner.
```yaml
entry: uv run --no-project --with "clang-tidy==18.1.8" python
tests/lint/clang_tidy_precommit.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
