gemini-code-assist[bot] commented on code in PR #18649:
URL: https://github.com/apache/tvm/pull/18649#discussion_r2676682534
##########
src/relax/op/tensor/index.cc:
##########
@@ -84,8 +84,7 @@ StructInfo InferStructInfoTake(const Call& call, const
BlockBuilder& ctx) {
}();
if (indices_sinfo->IsUnknownDtype()) {
- // TODO(tvm-team): Do we have an equivalent of `ctx->ReportFatal` for
warning?
- LOG(WARNING) << "Data type of indice has not been specified. Assume it has
an integer type.";
+ LOG(WARNING) << "Data type of index has not been specified. Assume it has
an integer type.";
Review Comment:
For improved clarity, consider using "indices" instead of "index", as this
warning refers to the `indices` tensor argument.
```suggestion
LOG(WARNING) << "Data type of indices has not been specified. Assume it
has an integer type.";
```
##########
src/relax/op/tensor/manipulate.cc:
##########
@@ -2617,7 +2617,7 @@ StructInfo InferStructInfoScatterElements(const Call&
call, const BlockBuilder&
}
if (indices_sinfo->IsUnknownDtype()) {
- LOG(WARNING) << "Data type of indice has not been specified. Assume it has
an integer type.";
+ LOG(WARNING) << "Data type of index has not been specified. Assume it has
an integer type.";
Review Comment:
For improved clarity, consider using "indices" instead of "index", as this
warning refers to the `indices` tensor argument.
```suggestion
LOG(WARNING) << "Data type of indices has not been specified. Assume it
has an integer type.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
