junrushao commented on code in PR #400: URL: https://github.com/apache/tvm-ffi/pull/400#discussion_r2680397859
########## CMakeLists.txt: ########## @@ -122,10 +123,8 @@ endif () tvm_ffi_add_msvc_flags(tvm_ffi_objs) tvm_ffi_add_target_from_obj(tvm_ffi tvm_ffi_objs) -find_package(Threads) -if (Threads_FOUND) - # link to threads library if found on some cross-compilation platforms, the threads library maynot - # be found but downstream may still be able to build extra alternatives via source bundle +if (TVM_FFI_USE_THREADS) + find_package(Threads REQUIRED) target_link_libraries(tvm_ffi_shared PRIVATE Threads::Threads) Review Comment: indent this line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
