gemini-code-assist[bot] commented on code in PR #401: URL: https://github.com/apache/tvm-ffi/pull/401#discussion_r2680666920
########## CMakeLists.txt: ########## @@ -129,7 +130,10 @@ if (TVM_FFI_USE_THREADS) target_link_libraries(tvm_ffi_static INTERFACE Threads::Threads) endif () -if (TVM_FFI_USE_EXTRA_CXX_API AND CMAKE_DL_LIBS) +if (TVM_FFI_USE_EXTRA_CXX_API + AND CMAKE_DL_LIBS + AND TVM_FFI_USE_DL_LIBS +) Review Comment:  For consistency with other conditional statements in this file and for improved readability, it's better to have this `if` condition on a single line. The resulting line is not excessively long and would align with the common style in this `CMakeLists.txt`. ``` if (TVM_FFI_USE_EXTRA_CXX_API AND CMAKE_DL_LIBS AND TVM_FFI_USE_DL_LIBS) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
