gemini-code-assist[bot] commented on PR #18725: URL: https://github.com/apache/tvm/pull/18725#issuecomment-3864718274
## Summary of Changes Hello @mshr-h, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug where scalar parameters were not being properly recognized and passed to the Relax VM through the Dynamo frontend. The changes ensure that zero-dimensional `torch.Tensor` inputs are now correctly processed, resolving a reported issue and enhancing the compatibility and robustness of the PyTorch-Relax integration. Additionally, it includes a refinement in how constant expressions are handled during graph translation to improve type consistency. ### Highlights * **Scalar Parameter Input Fix**: Resolved an issue where scalar `torch.Tensor` arguments were not correctly forwarded to the Relax VM when using the Dynamo frontend. * **Constant Expression Handling**: Refined the logic for handling constant expressions in binary operations within the graph translator to prevent incorrect type casting when both operands are constants. * **New Test Case**: Introduced a new test, `test_relax_dynamo_scalar_params`, to specifically validate the correct processing of scalar `torch.nn.Parameter`s by the Relax Dynamo backend. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **python/tvm/relax/frontend/torch/base_fx_graph_translator.py** * Modified `call_binary_op` to add explicit checks (`and not isinstance(rhs, relax.expr.Constant)`) when promoting types for binary operations involving `relax.expr.Constant` to avoid redundant or incorrect casting if both operands are already constants. * **python/tvm/relax/frontend/torch/dynamo.py** * Removed the `if arg.dim() != 0:` condition within `exec_tvm`, allowing scalar `torch.Tensor` arguments (tensors with zero dimensions) to be converted to TVM tensors and passed to the VM. * **tests/python/relax/test_frontend_dynamo.py** * Added `test_relax_dynamo_scalar_params`, a new test case that defines a `torch.nn.Module` with scalar parameters and verifies that `torch.compile` with `relax_dynamo` produces the correct output. </details> <details> <summary><b>Activity</b></summary> * No human activity (comments, reviews, etc.) has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
