gemini-code-assist[bot] commented on code in PR #18727:
URL: https://github.com/apache/tvm/pull/18727#discussion_r2777751994
##########
python/tvm/contrib/mrvl.py:
##########
@@ -222,7 +222,7 @@ def modify_const_names(nodes_json_str, consts_json_str):
-------
modified_nodes_consts: string
This returns a concatenated string of the nodes_json and modified
- consts json file, seperated by a delimiter |. The modification to the
+ consts json file, separated by a delimiter |. The modification to the
Review Comment:
Good catch on this typo. I found another one in the same docstring on line
210: `... by build an generates ...` should probably be `... by build and
generates ...`.
##########
python/tvm/relax/transform/transform.py:
##########
@@ -1618,7 +1618,7 @@ def AllocateWorkspace() -> tvm.ir.transform.Pass:
def SpecializePrimFuncBasedOnCallSite() -> tvm.ir.transform.Pass:
"""This pass updates the var_buffer mapping of PrimFunctions from the
call_tir info.
- Primarily used to update the VDevice information if any changes occured
from the caller.
+ Primarily used to update the VDevice information if any changes occurred
from the caller.
This pass recreates the buffers and updates the map.
Returns
Review Comment:
The description for the return value on line 1627 appears to be incorrect.
It seems to have been copied from the `AllocateWorkspace` function. It should
describe what `SpecializePrimFuncBasedOnCallSite` returns, for example: 'The
registered pass for specializing PrimFuncs based on call site.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
