gemini-code-assist[bot] commented on PR #18733: URL: https://github.com/apache/tvm/pull/18733#issuecomment-3866059966
## Summary of Changes Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where `has_attr` pattern matching failed for integer attributes due to the strict type requirements of `StructuralEqual`. By introducing a new `AttrValueEqual` helper, the system now performs value-based integer comparisons and recursively handles arrays, allowing Python-specified pattern values to correctly match actual operator attributes. This enhancement improves the robustness and flexibility of attribute pattern matching within the dataflow matcher, ensuring more reliable pattern recognition. ### Highlights * **Lenient Integer Attribute Matching**: Introduced a new helper function, `AttrValueEqual`, in `dataflow_matcher.cc` to perform lenient integer comparisons for attribute values, addressing issues where `StructuralEqual` required exact `dtype` matches for `IntImm`. * **Integration of New Comparison Logic**: Replaced all instances of `StructuralEqual` with the new `AttrValueEqual` within the `MatchAttrs` function, ensuring consistent and flexible attribute matching for both dictionary-style and reflection-based attributes. * **Test Case Re-enablement and Fix**: Re-enabled a previously disabled assertion in `test_op_attr` that validates `has_attr` pattern matching, and corrected the operator name from `nn.conv2d` to `relax.nn.conv2d`. * **Documentation Update**: Updated the docstring for `AttrPattern` in `pattern.py` to accurately reflect its support for Op, Call, and Function attributes, expanding on its previously stated limitation. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **python/tvm/relax/dpl/pattern.py** * Updated the docstring for `AttrPattern` to clarify its support for Op, Call, and Function attributes. * **src/relax/ir/dataflow_matcher.cc** * Added `AttrValueEqual` function for lenient integer and recursive array comparison of attribute values. * Replaced `StructuralEqual` with `AttrValueEqual` in `MatchAttrs` for both dict-style and reflection-based attribute matching. * **tests/python/relax/test_dataflow_pattern.py** * Re-enabled a previously disabled assertion in `test_op_attr` for `has_attr` pattern matching. * Corrected the operator name in the re-enabled assertion from `nn.conv2d` to `relax.nn.conv2d`. * Removed a redundant failing assertion. </details> <details> <summary><b>Activity</b></summary> * A previously disabled test assertion related to `has_attr` pattern matching for `nn.conv2d` was re-enabled and fixed, indicating a prior issue that prevented its successful execution. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
