gemini-code-assist[bot] commented on code in PR #18735:
URL: https://github.com/apache/tvm/pull/18735#discussion_r2779369310
##########
src/s_tir/meta_schedule/database/database.cc:
##########
@@ -296,33 +297,34 @@ TVM_FFI_STATIC_INIT_BLOCK() {
TVM_FFI_STATIC_INIT_BLOCK() {
namespace refl = tvm::ffi::reflection;
refl::GlobalDef()
- .def("meta_schedule.Workload", [](IRModule mod) { return Workload(mod);
})
- .def_method("meta_schedule.WorkloadAsJSON", &WorkloadNode::AsJSON)
- .def("meta_schedule.WorkloadFromJSON", &Workload::FromJSON)
- .def("meta_schedule.TuningRecord",
+ .def("s_tir.meta_schedule.Workload", [](IRModule mod) { return
Workload(mod); })
+ .def_method("s_tir.meta_schedule.WorkloadAsJSON", &WorkloadNode::AsJSON)
+ .def("s_tir.meta_schedule.WorkloadFromJSON", &Workload::FromJSON)
+ .def("s_tir.meta_schedule.TuningRecord",
[](s_tir::Trace trace, Workload workload,
ffi::Optional<ffi::Array<FloatImm>> run_secs,
ffi::Optional<Target> target, ffi::Optional<ffi::Array<ArgInfo>>
args_info) {
return TuningRecord(trace, workload, run_secs, target, args_info);
})
- .def_method("meta_schedule.TuningRecordAsMeasureCandidate",
+ .def_method("s_tir.meta_schedule.TuningRecordAsMeasureCandidate",
Review Comment:
The FFI registration for `TuningRecordAsMeasureCandidate` seems to have been
accidentally removed instead of being renamed. This will break the
`TuningRecord.as_measure_candidate()` method in Python. Please add it back.
```suggestion
.def_method("s_tir.meta_schedule.TuningRecordAsMeasureCandidate",
&TuningRecordNode::AsMeasureCandidate)
.def_method("s_tir.meta_schedule.TuningRecordAsJSON",
&TuningRecordNode::AsJSON)
```
##########
CMakeLists.txt:
##########
@@ -290,13 +290,10 @@ assign_source_group("Include" ${GROUP_INCLUDE})
# Source file lists
tvm_file_glob(GLOB_RECURSE COMPILER_SRCS
- src/auto_scheduler/*.cc
Review Comment:
The removal of `src/auto_scheduler/*.cc` (and `src/autotvm/*.cc` on line
299) seems out of scope for a PR that is migrating `meta_schedule`. If this is
intended, it would be better to move this change to a separate PR with a more
descriptive title to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
