gemini-code-assist[bot] commented on code in PR #18746: URL: https://github.com/apache/tvm/pull/18746#discussion_r2788574173
########## cmake/libs/Libbacktrace.cmake: ########## @@ -1,4 +1,4 @@ -# Licensed to the Apache Software Foundation (ASF) under one +# Licensed to the Apache Software Foundation (ASF) under one Review Comment:  A UTF-8 Byte Order Mark (BOM) has been added to the beginning of this file. This is often an unintentional artifact from a text editor and can cause issues with some tools and scripts that do not expect it. It should be removed to ensure file compatibility. ########## cmake/libs/Libbacktrace.cmake: ########## @@ -59,8 +59,8 @@ tvm_file_glob(GLOB LIBBACKTRACE_SRCS "${CMAKE_CURRENT_LIST_DIR}/../../3rdparty/l ExternalProject_Add_Step(project_libbacktrace checkout DEPENDERS configure DEPENDEES download - DEPENDS ${LIBBACKTRACE_SRCS} + DEPENDS ${LIBBACKTRACE_SRcs} Review Comment:  There appears to be a typo in the variable name. It was changed from `LIBBACKTRACE_SRCS` to `LIBBACKTRACE_SRcs`. CMake variable names are case-sensitive, and `LIBBACKTRACE_SRcs` is not defined (the variable is defined as `LIBBACKTRACE_SRCS` on line 58). This will break the custom step's dependency on the source files, meaning changes to `libbacktrace` sources won't trigger a rebuild. ``` DEPENDS ${LIBBACKTRACE_SRCS} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
