gemini-code-assist[bot] commented on PR #18764: URL: https://github.com/apache/tvm/pull/18764#issuecomment-3888356230
## Summary of Changes Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial optimization to the constant folding pass by preventing the folding of large creation operations that lack tensor inputs. This change significantly reduces the size of the compiled binary by avoiding the unnecessary embedding of large, easily computable constants, thereby improving overall efficiency without compromising correctness. ### Highlights * **Constant Folding Heuristic**: Implemented a new heuristic in the `ShouldBeFolded` function to prevent constant folding of large creation operations (e.g., `zeros`, `ones`, `full`, `arange`) that do not have tensor inputs. This avoids materializing large constants into the binary when they are cheap to compute at runtime. * **Tensor Input Detection**: Enhanced the logic to accurately detect tensor inputs, including checking for tensors nested within tuples, which is relevant for operations like `call_tir`. * **New Test Cases**: Added comprehensive test cases to validate the new folding behavior, covering scenarios for large creation ops that should not be folded, small creation ops that should be folded, and large ops with tensor inputs that should still be folded. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **src/relax/transform/fold_constant.cc** * Implemented a heuristic in `ShouldBeFolded` to skip folding for creation ops producing more than 1024 elements if they have no tensor inputs. * Added logic to check for tensor inputs, including those within tuple arguments, to determine if an operation is a pure creation op. * **tests/python/relax/test_transform_fold_constant.py** * Added `test_skip_folding_large_creation_op` to verify that large creation ops without tensor inputs are not folded. * Added `test_fold_small_creation_op` to confirm that small creation ops are still correctly folded. * Added `test_fold_large_op_with_tensor_input` to ensure that large ops with tensor inputs are folded as expected. </details> <details> <summary><b>Activity</b></summary> * No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
