gemini-code-assist[bot] commented on code in PR #18775: URL: https://github.com/apache/tvm/pull/18775#discussion_r2804740383
########## ci/jenkins/docker-images.ini: ########## @@ -17,8 +17,8 @@ # This data file is read during when Jenkins runs job to determine docker images. [jenkins] -ci_arm: tlcpack/ci-arm:20250513-063354-70aa3797 -ci_cpu: tlcpack/ci_cpu:20250513-063354-70aa3797 -ci_gpu: tlcpack/ci-gpu:20250513-063354-70aa3797 -ci_lint: tlcpack/ci-lint:20250513-063354-70aa3797 -ci_wasm: tlcpack/ci-wasm:20250513-063354-70aa3797 +ci_arm: tlcpack/ci-arm:20260213-110714-021547fe +ci_cpu: tlcpack/ci_cpu:20260213-110714-021547fe +ci_gpu: tlcpack/ci-gpu:20260213-110714-021547fe +ci_lint: tlcpack/ci-lint:20260213-110714-021547fe +ci_wasm: tlcpack/ci-wasm:20260213-110714-021547fe Review Comment:  To improve maintainability and reduce redundancy, consider defining the image tag as a variable and reusing it. This would make future updates easier and reduce the chance of inconsistencies. For example, you could add a `ci_tag` variable under the `[jenkins]` section and reference it: ```ini ci_tag: 20260213-110714-021547fe ci_arm: tlcpack/ci-arm:${ci_tag} ci_cpu: tlcpack/ci_cpu:${ci_tag} ci_gpu: tlcpack/ci-gpu:${ci_tag} ci_lint: tlcpack/ci-lint:${ci_tag} ci_wasm: tlcpack/ci-wasm:${ci_tag} ``` This change would depend on the parser for this file supporting variable interpolation. If that's not feasible, the current explicit approach is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
