Hey list, 'extended_encoder' currently ignores whatever 'get_output_conversion' returns. If you use FEC's extended encoder and you reimplement 'get_output_conversion', it gets ignored. A quick look at the available encoders in gr-fec shows, that none of them actually uses that method. Though the docs state that * If 'packed_bits', the block produces packed bits and the * wrapper should unpack these (using, for instance, * gr::block::unpack_k_bits_bb(8)).
Thus I created a little patch which would fix that. Also I just sent a pull request for that. Johannes
>From a20761005e60335da2cb78104a6f1c4b576aa3c2 Mon Sep 17 00:00:00 2001 From: Johannes Demel <uf...@student.kit.edu> Date: Thu, 18 Jun 2015 20:13:52 +0200 Subject: [PATCH] fec: extended encoder now appends unpack_k_bits(8) block after encoder to satisfy get_output_conversion() = unpack behaviour --- gr-fec/python/fec/extended_encoder.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gr-fec/python/fec/extended_encoder.py b/gr-fec/python/fec/extended_encoder.py index 50a8891..1c6da0e 100644 --- a/gr-fec/python/fec/extended_encoder.py +++ b/gr-fec/python/fec/extended_encoder.py @@ -60,6 +60,9 @@ class extended_encoder(gr.hier_block2): gr.sizeof_char, gr.sizeof_char)) + if fec.get_encoder_output_conversion(encoder_obj_list[0]) == "packed_bits": + self.blocks.append(blocks.packed_to_unpacked_bb(1, gr.GR_MSB_FIRST)) + if self.puncpat != '11': self.blocks.append(fec.puncture_bb(len(puncpat), read_bitlist(puncpat), 0)) -- 1.9.1
_______________________________________________ Discuss-gnuradio mailing list Discuss-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/discuss-gnuradio