Hello everyone, Thanks for the detailed review. I have made changes to my proposal to incorporate review/merge cycle, build Python API for the modtool, briefly explain the UI enhancements and fix typos. I am still quite unsure about the automated testing part. But as of now, thorough testing will be done locally. Please review the updated version of my proposal. Thanks! :) Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf Code Link: https://github.com/swap-nil7/GSoC-Proposal
On Tue, Mar 20, 2018 at 12:33 AM, swapnil negi <swapnil.neg...@gmail.com> wrote: > Hello everyone! > I have uploaded my proposal to the GitHub pages. So, please review and > provide me suggestions to improve the same. > Proposal Link: https://swap-nil7.github.io/gsoc-proposal.pdf > Code Link: https://github.com/swap-nil7/GSoC-Proposal > Thank You! > > Regards, > Swapnil Negi > Indian Institute of Technology Roorkee > India > > > On Sat, Mar 17, 2018 at 3:09 AM, swapnil negi <swapnil.neg...@gmail.com> > wrote: > >> Hi Nicoloas! >> Thanks for your valuable response. >> Regarding Python compatibility - I will work upon version independent >> compatibility using information from the following links: >> Link[1] <http://python3porting.com/noconv.html> Link[2] >> <http://python-future.org/compatible_idioms.html> >> Regarding specific milestones - I have now listed the work that can be >> assessed after the completion of various phases. >> Regarding CV: I have removed the section of such personal details from >> the CV as well as proposal. >> >> Cheers, >> Swapnil Negi >> >> On Fri, Mar 16, 2018 at 5:45 PM, Nicolas Cuervo <nicolas.cue...@ettus.com >> > wrote: >> >>> Hello Swapnil Negi, >>> >>> Thank you for your proposal! This project has been in the pipeline for >>> long and I'm very excited to see your interest in working on it. I have >>> very few comments for now, but the discussion can definitely continue open: >>> >>> So the timeline that you are proposing is: >>> 1) Python3 Compatible >>> 2) Implement Plugin Architecture >>> 3) Restructure code in favor of functional behavior >>> 4) work on UI if time allows >>> >>> And I agree with this timeline, as it puts core focus on the >>> architectural overhaul without disregarding other details aside. >>> >>> - If I understand correctly, your first task to tackle is the Py3k >>> compatibility, which is great. This is definitely something that needs to >>> be done, as there is a continuous effort on making the whole GNURadio >>> Python3 compatible. But Python2 is not EOL for little less than 2 years >>> more, so continuous compatibility is something that has to be kept in >>> mind. >>> Let's take your proposed code for raiseException, whose implementation >>> won't work on Python2. There are ways to ensure compatibility (using >>> wrappers from 'six' for example, which adds a dependency - which can be >>> discussed) >>> I, however, see that the Python3 branch from GNU Radio already >>> implements the syntax that you are proposing, so I might being just too >>> picky on this. I expect comments on the matter from the list. >>> >>> - I see that you have put efforts in contributing already to the >>> project by fixing some issues on the tool, and there is hardly a better >>> way >>> to get used to it and contribute to the project. No comment here apart >>> from >>> saying that we do appreciate you took that path as it puts you into >>> context >>> and improves the project. Win-Win! >>> >>> - I would work on the format of the proposal as well to help you >>> make a better impression and increases your chances of this being >>> accepted. >>> In your timeline, be sure to explicitly say what deliverable can be >>> expected when. It's good to know when you are going to start working on >>> something, but it is also important to know when you are expected to have >>> it finished. Words like "Milestone" or even "Deliverable" might make this >>> clear, maybe around the evaluation dates. >>> >>> - I see that you included your CV, which is nice to have, but do you >>> _really_ want your personal data (like phone and address) out in the >>> open? >>> >>> >>> I might come back with more comments, but for now this is looking >>> promising! >>> >>> Cheers, >>> - Nicolas >>> >>> >>> On Fri, Mar 16, 2018 at 3:57 AM, swapnil negi <swapnil.neg...@gmail.com> >>> wrote: >>> >>>> Hello everyone, I am Swapnil Negi, an undergraduate from Indian >>>> Institute of Technology Roorkee, India. I wish to contribute to the project >>>> idea "gr-modtool overhaul". Here >>>> <https://docs.google.com/document/d/10Nx0tWRlSP43GOCrdSoCVHmcStsZWiKJHNmsdc07MPo/edit?usp=sharing> >>>> is the draft of my proposal. Kindly review it and give your valuable >>>> suggestins. >>>> This is something that I expected from the discussion. If there's >>>> something that I am missing out, please do inform me. >>>> Thanks! >>>> >>>> Regards, Swapnil Negi >>>> >>>> >>>> _______________________________________________ >>>> Discuss-gnuradio mailing list >>>> Discuss-gnuradio@gnu.org >>>> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio >>>> >>>> >>> >> >
_______________________________________________ Discuss-gnuradio mailing list Discuss-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
