Hi Andreas, I did this, and as far as I remember I even tought about it before making this and other changes. What do you think is wrong here? The reason I made that change was that NSTabView keeps he selection twice. Once in _selected_item and also _selected (I am doing this from memory as I am over here at FOSDEM) and we need to make sure these two match in some way. And what I tried to do was just this. If I failed on doing so, please show me my wrongs.
Cheers, Fred -------- Original-Nachricht -------- Datum: Fri, 23 Feb 2007 22:51:06 +0100 Von: "Andreas Höschler" <[EMAIL PROTECTED]> An: [email protected] CC: Betreff: NSTabView Fix > Hello all, > > somebody has modified the following NSTabView.m method recently. Don't > do that! > > - (void) insertTabViewItem: (NSTabViewItem*)tabViewItem > atIndex: (int)index > { > [tabViewItem _setTabView: self]; > [_items insertObject: tabViewItem atIndex: index]; > > /* *** You do not really want to do that; think about it!!! > if ((_selected_item != NSNotFound) && (index <= _selected_item)) > { > _selected_item++; > }*/ > > if ([_delegate respondsToSelector: > @selector(tabViewDidChangeNumberOfTabViewItems:)]) > { > [_delegate tabViewDidChangeNumberOfTabViewItems: self]; > } > > /* TODO (Optimize) - just mark the tabs rect as needing redisplay */ > [self setNeedsDisplay: YES]; > } > > Regards, > > Andreas > > > > _______________________________________________ > Discuss-gnustep mailing list > [email protected] > http://lists.gnu.org/mailman/listinfo/discuss-gnustep -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out _______________________________________________ Discuss-gnustep mailing list [email protected] http://lists.gnu.org/mailman/listinfo/discuss-gnustep
