Hi, Hugo Melder wrote:
In the past weeks I have seen pushes to the master branch that did not go through a proper review process. Some of the commits did not even pass the CI.
only core persons can commit, the repository is not really open, so it can only be "one of us".
Can we please move to a sane approach and protect the master branch? All work shall be done on feature branches instead, according to best practice. We have been doing this in libobjc2 for years now and it works great.
I remember we had a discussion about that, including Richard, and we decided to keep it informal. Most work is done on PR but the repository was not protected. Personally I stand with that approach and follow the guideline that 99% of the time I make a PR, but other core maintainers should express their view. Richard, Fred...
I'm mostly concerned about gnustep-base right now.
Honestly, I don't see a concern here. What is broken can be fixed or reverted. It is not "clean" but still we are referring to master branch which is equivalent to development. It is not release neither it is a "stable" branch.
Just my 2ยข Riccardo
