ACK

Chrissie

On 23/01/14 16:32, Jan Friesse wrote:
Patch f3ffd3da5c71a10e1783a38e50bafc61192854f6 introduced named states
of state-machine, but sadly contains logical problem causing
stats.continuous_gather increasing even when it shouldn't. Problem is
not critical, because continuous_gather is set to 0 on successful
membership creation.

Signed-off-by: Jan Friesse <[email protected]>
---
  exec/totemsrp.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/exec/totemsrp.c b/exec/totemsrp.c
index a1397d1..5f5b7be 100644
--- a/exec/totemsrp.c
+++ b/exec/totemsrp.c
@@ -2089,7 +2089,7 @@ static void memb_state_gather_enter (
        instance->memb_state = MEMB_STATE_GATHER;
        instance->stats.gather_entered++;

-       if (TOTEMSRP_GSFROM_THE_CONSENSUS_TIMEOUT_EXPIRED == 3) {
+       if (gather_from == TOTEMSRP_GSFROM_THE_CONSENSUS_TIMEOUT_EXPIRED) {
                /*
                 * State 3 means gather, so we are continuously gathering.
                 */


_______________________________________________
discuss mailing list
[email protected]
http://lists.corosync.org/mailman/listinfo/discuss

Reply via email to