Well, that’s… enlightening. (C++ kernel modules — ick. Ok, I don’t like C++.
But talk about the wrong tool for the job… sheesh.)
As far as a “backout”, I don’t think we have the source history to do a git
revert. But careful removal should be possible, perhaps scrubbing one kernel
module at a time.
- Garrett
> On Dec 23, 2014, at 11:05 AM, Dan McDonald <[email protected]> wrote:
>
>
>> On Dec 23, 2014, at 1:53 PM, Garrett D'Amore via illumos-discuss
>> <[email protected]> wrote:
>>
>> For various reasons, I’m trolling through the bowels of the illumos IP
>> stack, and there is a bunch of stuff there to support the Solaris Cluster
>> product. This is an HA clustering solution offered by Oracle on Solaris.
>> It does a fair bit in the kernel.
>
> AND it's the reason we can't use C++ keywords in the kernel. I'm actually
> okay enforcing that rule, but for historians and archaeologists in the
> audience, it's Solaris Cluster (and its <ewww>C++ kernel modules</ewww>) that
> caused the no-C++-keyword rule.
>
>> In theory Oracle open sourced the HA cluster product a while ago. I can’t
>> find the source at the moment, though.
>>
>> I’m curious, has anyone *ever* successfully gotten this product to run on
>> illumos? Has anyone ever *tried*?
>>
>> Rationale here is that if it doesn’t work, and is never going to work, I can
>> clean up some dead code that is on very hot code paths. This can have
>> ramifications for performance, particularly in latency sensitive parts of
>> the stack. (Where I live, every us counts.)
>
> I helped with some of the changes in question back in the day (the bits where
> they replicated the IPsec SADB between nodes).
>
> I'm okay with backing these out so long as the backouts are somewhat
> documented (in case some grinning weirdo wants to restore them in his/her own
> private repo). And please be careful, at least with IPsec, some of the
> cluster-related changes contain non-cluster goodness, so just doing "git
> revert" might not be the smartest thing to do.
>
> Thanks!
> Dan
>
-------------------------------------------
illumos-discuss
Archives: https://www.listbox.com/member/archive/182180/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be
Modify Your Subscription:
https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4
Powered by Listbox: http://www.listbox.com
