On Sun, Oct 11, 2015 at 06:31:18PM +0200, Richard PALO wrote:
> Le 10/10/15 11:45, Josef 'Jeff' Sipek a écrit :
> >
> > I think it is way too late. We would have to rewrite the history...and tell
> > everyone to reclone all gates
> >
> > It is up to the advocates to make sure that what they commit is valid. I
> > don't know if they automate things at all, but if they do it should be easy
> > to add a commit metadata check.
> >
> > Jeff.
> >
>
> Too bad this wasn't done when the git repos were done. Although I would
> have a hard time imagining any developer that would not want to have these
> turds cleaned up. I'd rather reclone than be annoyed by git fsck.
> Hopefully I'm not alone.
I think most people don't run git-fsck (often). There is also something to
be said about preserving history - even if it isn't pretty. (FWIW, based on
a spot check, a number of these bad author strings are from the osol days.)
> BTW, I am presuming that these are [still] in all the git repos... is that
> a valid assumption?
All the git repos? Well, yes... every clone of illumos-gate has those.
These bad strings were in the mercurial repo for a long time the hg->git
conversion preserved them since the conversion is supposed to be lossless.
Jeff.
--
I'm somewhere between geek and normal.
- Linus Torvalds
-------------------------------------------
illumos-discuss
Archives: https://www.listbox.com/member/archive/182180/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be
Modify Your Subscription:
https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4
Powered by Listbox: http://www.listbox.com
