I've looked at this in the past. I wasn't able to find any particular power of two requirement. That doesn't mean it isn't there but if you've been running this way for a while I would go ahead and RTI it. Count me as a reviewer.
Sent from my iPhone > On Oct 20, 2015, at 10:30 PM, Richard PALO <[email protected]> wrote: > > Le 24/07/14 23:01, Garrett D'Amore via illumos-discuss a écrit : >> Ignore it. I should really remove the warning. I need to check into the >> reason it disables dr though. > > I've been running the following for awhile: >> richard@omnis:/home/richard/src/illumos-gate$ git show 76d5d7a4fd3 >> commit 76d5d7a4fd382bfb74f1484335ca8e9395382f1c >> Author: Richard PALO <[email protected]> >> Date: Sat May 16 14:09:30 2015 +0200 >> >> drmach_init should support 12 cpus (not a power of 2) >> >> diff --git a/usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c >> b/usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c >> index 8f93c2d..7078347 100644 >> --- a/usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c >> +++ b/usr/src/uts/i86pc/io/acpi/drmach_acpi/drmach_acpi.c >> @@ -895,11 +895,6 @@ drmach_init(void) >> "(%d) physical processors on one board.", >> MAX_CMP_UNITS_PER_BOARD); >> return (ENXIO); >> - } else if (!ISP2(MAX_CORES_PER_CMP)) { >> - cmn_err(CE_WARN, "!drmach_init: number of logical CPUs (%d) >> in " >> - "physical processor is not power of 2.", >> - MAX_CORES_PER_CMP); >> - return (ENXIO); >> } else if (MAX_CPU_UNITS_PER_BOARD > DEVSET_CPU_NUMBER || >> MAX_MEM_UNITS_PER_BOARD > DEVSET_MEM_NUMBER || >> MAX_IO_UNITS_PER_BOARD > DEVSET_IO_NUMBER) { > > but I haven't checked into any other side effects... it would be nice to put > this > to sleep if anyone knowlegeable (garrett) could do a quick, educated look > where it may matter. > > > -- > Richard PALO > ------------------------------------------- illumos-discuss Archives: https://www.listbox.com/member/archive/182180/=now RSS Feed: https://www.listbox.com/member/archive/rss/182180/21175430-2e6923be Modify Your Subscription: https://www.listbox.com/member/?member_id=21175430&id_secret=21175430-6a77cda4 Powered by Listbox: http://www.listbox.com
