Vasilii, Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <[email protected]> wrote: > Greetings, Sergey! > > Before I create a pull request, I want to ask how it would be convenient > to interact (I estimate around 1000 words to be changed): > 1. I'll make small patches (one alphabet letter at a time or 50 words at a > time) and create PR for each take separately; > 2. I'll make exact same patches, but with one PR; > 3. One big patch, one PR? > > I'm concerned about: > 1. Checking a single patch will be too much of a hassle; > 2. Approving each PR will be a hassle as well. > > Or maybe there are better options that I don't know about. > Thank you for response. > > Best regards, > Vasilii > > 19.02.2025 17:00, Sergey Vojtovich wrote: > > Hi Vasilii, > > Yes, please go ahead and create pull request against "main" branch. > https://github.com/MariaDB/server/pulls > > Regards, > Sergey > > On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss < > [email protected]> wrote: > >> Forgot to attach the patch I mentioned. >> _______________________________________________ >> discuss mailing list -- [email protected] >> To unsubscribe send an email to [email protected] >> >
_______________________________________________ discuss mailing list -- [email protected] To unsubscribe send an email to [email protected]
