Oh, sorry. I was thinking this was in the datapath, and the kernel has it defined there. Yes, this is better.
--Justin On May 19, 2010, at 9:03 AM, Ben Pfaff wrote: > I'd prefer to use > #include <sys/stat.h> > since it's the standard header for S_ISCHR. > > On Wed, May 19, 2010 at 08:37:31AM -0700, Justin Pettit wrote: >> Can you try adding "#include <linux/stat.h>" to the top of dpif-linux.c >> amongst all the other "#include <linux/...> statements? If that fixes the >> problem, we'll get that checked into the repository. >> >> Thanks! >> >> --Justin >> >> >> On May 19, 2010, at 6:52 AM, DarkBls wrote: >> >>> Hi. >>> >>> I just tested to compile OvS 1.0.0 on Fedora 13 beta with no luck : >>> >>> [...] >>> gcc -Wstrict-prototypes -Wall -Wno-sign-compare -Wpointer-arith >>> >>> -Wdeclaration-after-statement -Wformat-security -Wswitch-enum >>> -Wunused-parameter -Wstrict-aliasing -Wbad-function-cast -Wcast-align >>> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes >>> -Wmissing-field-initializers -Wno-override-init -g -O2 -export-dynamic >>> -o utilities/ovs-dpctl utilities/ovs-dpctl.o lib/libopenvswitch.a -lm >>> lib/libopenvswitch.a(dpif-linux.o): In function `make_openvswitch_device': >>> /root/openvswitch/openvswitch-1.0.0/lib/dpif-linux.c:630: undefined >>> reference to `S_ISCHR' >>> collect2: ld a retourné 1 code d'état d'exécution >>> make[2]: *** [utilities/ovs-dpctl] Erreur 1 >>> make[2]: quittant le répertoire « /root/openvswitch/openvswitch-1.0.0 » >>> make[1]: *** [all-recursive] Erreur 1 >>> make[1]: quittant le répertoire « /root/openvswitch/openvswitch-1.0.0 » >>> make: *** [all] Erreur 2 >>> Is there something to do on my own ? >>> >>> >>> >>> >>> >>> _______________________________________________ >>> discuss mailing list >>> discuss@openvswitch.org >>> http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org >> >> >> _______________________________________________ >> discuss mailing list >> discuss@openvswitch.org >> http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org _______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org
