Hi Tim, Thanks again for the feed-back, I've reopened the issue and added a comment to your blog post.
Best regards, Jerome > -----Message d'origine----- > De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la > part de Tim Peierls > Envoyé : lundi 5 novembre 2007 21:34 > À : discuss@restlet.tigris.org > Objet : Re: Thread-safety in Guard > > On 11/4/07, Jerome Louvel <[EMAIL PROTECTED]> wrote: > > I've fixed the remaining Guard.secrets issue following > Tim advises: > - removed the setSecrets() method in trunk > - eagerly instantiate the secrets map > > I've also fixed potential issues with RouteList using > an underlying CopyOnWriteArrayList instance. > > If you see remaining threading issues, please reopen: > http://restlet.tigris.org/issues/show_bug.cgi?id=368 > > > > > I don't think I have permission to re-open it, but I added > the following comment: > > > > > The last set of changes is definitely an improvement, > but there are still a lot of outstanding concurrency problems. > > The secrets field of Guard should be final. > > In the Restlet class, the context field is not always > accessed with appropriate synchronization. > > None of the fields of the other classes in org.restlet > are accessed with appropriate synchronization. > > > > > I haven't looked at other packages yet. > > I posted a longer discussion of how these problems might be > addressed on my blog: > > http://tembrel.blogspot.com/2007/11/concurrency-issues-in-restlet.html > > --tim > >
