Jerome,
So this leaves me wondering:
Should getTargetRef() clear the baseref or do we have to rely on the verbose new Reference(getTargetRef().toString()) to do this ourselves ?

It think we should fix the code as suggested by the Javadocs, unless I'm
missing some other aspect. If all the unit tests pass after the change, then
we should be pretty safe. Let's only change this in 1.1 branch only for now.

=> issue 473 : I generated the diff against the trunk - which is the 1.1 branch I assume

And considering the request.getProtocol(): doesn't it make more sense to use the protocol of the targetref instead of the baseref when the targetref itself is absolute ?

Yes, I think so.
=> issue 474 : same remark as above

Kind regards,
Jeroen


**** DISCLAIMER ****
http://www.schaubroeck.be/maildisclaimer.htm

Reply via email to