Calling initRow is ok, but:
- I think there is no way to call it with the correct row number (the
patch always call it using 0,0 which is not so good)
- initRow is called multiple time and in tableDecorator is not defined
as final: users may have extended it and this can cause problems
- the call to initRow with 0 as line number for sorting should be
documented.

So I'll probably go on with:
- applying the suggested patch
- making initRow() final
- document it in the javadocs


Making the initRow method final could lead to incompatibility with old
tabledecorators: anyway there should be no reason for users to extend
initRow(), I think this should not cause problems...


fabrizio



-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Andy
Pruitt
Sent: Wednesday, October 15, 2003 12:17 AM
To: [EMAIL PROTECTED]
Subject: RE: [displaytag-devel] tiles and sorting



> -----Original Message-----
> From: Fabrizio Giustina [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, October 14, 2003 4:50 PM
> To: [EMAIL PROTECTED]
> Subject: RE: [displaytag-devel] tiles and sorting
> 
> 
> There is actually an open bug regarding sorting while using 
> table decorators. An easy fix is proposed on sf, but I'd like 
> to see if there is a more clean solution before applying that one. 


What are you looking for in a fix?  I don't see an easy way to avoid
the init() call; it seems the alternative would be to have a 
TableDecorator for every row?  



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
displaytag-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to