Alexandre Oliva wrote:- > Same here. I've already fixed the bug that caused the duplication of > <directory> entries, but I'll refrain from posting a revised patch for > now, since we're still discussing other issues. > > I'm thinking one way to handle it more efficiently would be to turn it > into a #pragma. Does this sound any better than the current > <directory> hack? > > #pragma GCC debugdir "/path/name"
This looks good at first glance. I image we'd only accept it if -fpreprocessed? > Also, any thoughts on the interface of the dir_change callback? > Should it take a const char *? Should the callback have to strdup() > the string itself, or may it just stick to whatever it is passed? I would suggest passing a const char * (along with pfile). The client shouldn't assume the text lasts forever IMO. Neil. __ distcc mailing list http://distcc.samba.org/ To unsubscribe or change options: http://lists.samba.org/cgi-bin/mailman/listinfo/distcc
