"Phillip J. Eby" <[EMAIL PROTECTED]> writes:

> At 03:24 PM 4/21/2008 -0400, Pete wrote:
> >On both linux & OS X, Setuptools installs all .py/.pyc files with mode
> >a+x (executable for all users).  This occurs regardless of original
> >the permissions in the source tarball.  Doing so breaks nosetests,
> >which by default refuses to import executable files for test-discovery
> >purposes as a safety measure.
> >
> >This behavior is broken & dangerous.
> 
> I don't see how it's either one.  An explanation would be helpful.

Broken: The source tarball has specific permissions set for those
files, and Setupttols is breaking that by overriding the permissions.
A feature (preserve desired permission mode of the file) is lost.

Dangerous: The tests will run fine on the developer's machine, but
will skip over the modules entirely when they are installed via
Setuptools, because of the above broken behaviour.

Test output will indicate no problems, because the permission modes
(as incorrectly set by Setuptools) indicate explicitly to the testing
tool that those modules should be skipped. This results in tests being
omitted silently, which is the danger.

(good sigmonster, have a cookie)

-- 
 \              “Ignorance more frequently begets confidence than does |
  `\           knowledge.” —Charles Darwin, _The Descent of Man_, 1871 |
_o__)                                                                  |
Ben Finney

_______________________________________________
Distutils-SIG maillist  -  [email protected]
http://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to