On Thu, Feb 14, 2013 at 6:15 AM, Reinout van Rees <[email protected]> wrote: > On 14-02-13 08:09, Chris Withers wrote: >>> >>> Thanks for this snippet, I would have had to look *much* harder >>> otherwise. >>> Now the only problem was cooking up a test case. Done in >>> https://github.com/buildout/buildout/pull/67 >> >> >> Awesome, thanks! Is it only Jim who can merge and do a release?
Anyone on the dev team can. They should: - Review the request carefully. - Accept it. Of course, someone other than the author should accept a pull request. Before release: - Make sure the tests pass on windows for at least some version of Python. - Make sure the travis tests pass I'm doing this for Reinout's 2 bug fixes. > For the one who's going to do it, I looked through the pull requests. > 62, 67 and 68 seem small enough for a quick 2.0.1 release: > > https://github.com/buildout/buildout/pull/62 (--version) This is a new feature. This would provoke a 2.1 release. I don't think it's urgent. I'll accept it after the 2.0.1 release. > https://github.com/buildout/buildout/pull/67 (fix for your __pycache__) > https://github.com/buildout/buildout/pull/68 (script encoding hint fix) I've accepted these, provoked a travis build and have run the windows tests. Once the travis tests run and pass (or fail with a certain spurious failure), I'll make a release. > > #51 is bigger, that's more 2.1 like. Conditions in sections. > > https://github.com/buildout/buildout/pull/51 In addition to the review, I need a contributor agreement from the author. > 18, 22 and 36 seem hairy or unneeded or lack tests. Yup. I think 36 has promise, but needs some work. I'll try to find time to comment on it soon. Jim -- Jim Fulton http://www.linkedin.com/in/jimfulton Jerky is better than bacon! http://zo.pe/Kqm _______________________________________________ Distutils-SIG maillist - [email protected] http://mail.python.org/mailman/listinfo/distutils-sig
