On Thu, Sep 3, 2015 at 9:56 AM, Daniel Holth <dho...@gmail.com> wrote:

> IIRC there's also a bug where we use pypy's version "2.6.2" and not the
> version of Python it implements "2.7" for the first tag.
>

It's the other way around:

https://github.com/pypa/pip/issues/2882

My changes set the Python tag to the version of PyPy.


> On Thu, Sep 3, 2015 at 9:53 AM Nate Coraor <n...@bx.psu.edu> wrote:
>
>> On Thu, Sep 3, 2015 at 8:16 AM, Donald Stufft <don...@stufft.io> wrote:
>>
>>> On September 3, 2015 at 8:15:53 AM, Daniel Holth (dho...@gmail.com)
>>> wrote:
>>> > We could at least merge the implementation of the SOABI tag for Python
>>> 2.7
>>> > (cp27m, cp27mu, ...), which has been in the PEP from the beginning but
>>> was
>>> > never implemented for Python 2. This lets you distinguish between
>>> wheels
>>> > built for CPython with debug, pymalloc, unicode builds.
>>> >
>>> > For pypy which does not have SOABI, the current 'none' should suffice.
>>>
>>
>> The ABI tag code as written will actually set it for PyPy (e.g.
>> 'pp222mu') since the SOABI config var is unset on it (and probably any
>> other non-Python-3 implementation). This was intentional since PyPy does
>> actually build some C Extensions, but I can limit SOABI detection to
>> CPython if it doesn't make sense to do it on PyPy.
>>
>> However, I see now it will also be set for Jython, which it definitely
>> should not do, so I'll fix that regardless.
>>
>
>>
>>> >
>>>
>>> Merging the SOABI tag sounds like a win to me.
>>>
>>
>> I'll create PRs for this against wheel and pip shortly. I can also work
>> on a PEP for the platform tag - I don't think it's going to need to be a
>> big one. Are there any preferences as to whether this should be a new PEP
>> or an update to 425?
>>
>>
>>>
>>> -----------------
>>> Donald Stufft
>>> PGP: 0x6E3CBCE93372DCFA // 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372
>>> DCFA
>>>
>>>
>>>
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@python.org
https://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to