On 5 December 2017 at 18:11, Dustin Ingram <di@di.codes> wrote:
>> I was a bit confused at first by the fact that you describe
>> environment markers but not where they are allowed. On checking, I
>> find that this is defined in version 1.2 (PEP 345). It might be worth
>> a small clarification that this (and name and version specifiers) are
>> still used in the same way as in PEP 345. Better to be explicit than
>> implicit and all that :-)
>
> Thanks Paul. I will add a note to to these sections indicating that
> their usage is otherwise unchanged from PEP 345.
>
>> Formatting nit - the "Name" section header is at a different level
>> than the other two. You probably want the other two with "::::"
>> underlines.
>
> Unless I'm misunderstanding your nit, I believe this is already the case?

Sorry, I was rushing and didn't take the time to fight with Gmail to
do inline comments. What I was trying to get at:

> Changed in Version 1.3
> ----------------------
>
> Name
> ::::
>
> The specification for the format of this field is now identical to the
> distribution name specification defined in PEP 508.
>
> Version Specifiers
> ==================

This should be

  ::::::::::::::::::

so "Version Specifiers" is at the same level as "Name"

>
> Version numbering requirements and the semantics for specifying comparisons
> between versions are defined in PEP 440.
>
> Environment markers
> ===================

Same here, should be

  :::::::::::::::::::

> An **environment marker** is a marker that can be added at the end of a
> field after a semi-colon (";"), to add a condition about the execution
> environment.
>
> The environment marker format used to declare such a condition is defined in
> the environment markers section of PEP 508.

Paul
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@python.org
https://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to