On Thu, Jul 12, 2018 at 12:32 AM, Robin Becker <ro...@reportlab.com> wrote:

> On 11/07/2018 19:44, Thomas Kluyver wrote:
>
>> On Wed, Jul 11, 2018, at 7:32 PM, Chris Jerdonek wrote:
>>
>>> And yet you can see "License: ReportLab BSD Derived" in the left-hand
>>> column under "Meta," so how did it get there? Did PyPI previously fall
>>> back to including the "License" classifier value as is (even if
>>> invalid) if no "license" field was present? Here's the project's
>>> setup(), which doesn't seem to have changed since 2013:
>>>
>> You used to be able to edit a release's metadata manually in a web form;
>> possibly the license was added that way.
>>
>> .......
> we certainly have not edited the metadata after upload. As Chris mentioned
> the classifier was in the package for a long time. I think the previous
> uploads were done via the old manual web page upload so perhaps that didn't
> check.


FYI, I found where the "fall back" logic from the license field to the
Trove classifiers is located. It's here in Warehouse:
https://github.com/pypa/warehouse/blob/79574e4c300c3786aebd8f43f3814bd2dc66ace5/warehouse/packaging/views.py#L100-L112

This logic was added a couple years ago. See the discussion for the PR here:
https://github.com/pypa/warehouse/pull/1284

--Chris





> My attempts to upload the latest reportlab-3.5.0.tar.gz failed initially
> with an obscure message from twine about string buffer being required.  I
> didn't discover what the problem there was, but I imagine another field has
> changed. I succeeded eventually after re-doing the sdist with a more modern
> virtual environment.
> --
> Robin Becker
>
--
Distutils-SIG mailing list -- distutils-sig@python.org
To unsubscribe send an email to distutils-sig-le...@python.org
https://mail.python.org/mm3/mailman3/lists/distutils-sig.python.org/
Message archived at 
https://mail.python.org/mm3/archives/list/distutils-sig@python.org/message/HLV44ZJP7KNBDDILQ6WGNR5HPMTHQREC/

Reply via email to