Review: Approve code [1] "A binding that that defines a function or class" -> duplicated "that".
[2] test_other.py line 133: there are four lines of whitespace here, between two methods, instead of 2. Thanks for replacing the dumb test-for-bad-behavior with a TODOed test for the desired behavior. I grabbed the branch, manually verified some behaviors (like class foo(foo) not emitting a warning), ran the unit tests, and reviewed the code itself. This looks good. With the above mentioned lexical changes you have my +1. I don't believe I have commit access to the trunk branch, so you'll have to get someone else who trusts my review to commit it. Sorry :-( -- https://code.launchpad.net/~jml/divmod.org/duplicate-class-defs/+merge/80813 Your team Divmod-dev is requested to review the proposed merge of lp:~jml/divmod.org/duplicate-class-defs into lp:divmod.org. -- Mailing list: https://launchpad.net/~divmod-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~divmod-dev More help : https://help.launchpad.net/ListHelp
