Hey Matt, On Thu, 2007-04-26 at 20:04 +0000, Matt Boersma wrote: > I had purposely let this thread dangle, hoping Malcolm or Adrian or > Jacob might weigh in and decide the "db_tablespace" minor controversy. > > But I hope this unresolved issue isn't perceived as holding up > integration of the Oracle patch. I don't think it should. At worst, > we could strip out the "db_tablespace" options altogether to simplify > the patch, then resurrect it as a separate patch on trunk once we know > which of the below options is preferred. I also think it's ok to > leave it as-is for now.
Sorry, I guess I wasn't paying enough attention. I hadn't actually realised there was a real controversy here. I'll go back and reread the thread with my eyes open. > So this is my "ping" to see if there's any general feedback on the > patch, and if there's any way we can facilitate it getting > incorporated. Not a complaint! [ducks head] I've been reading through the patch a couple of times. No real problems that I can see. Not unexpected, since it's clear you guys have clues and the Guiding Hand Of Jacob(tm) has been present from the outset. There are a couple of things we might need to flag as quasi-backwards-incompat issues. My list is on a computer that is shutdown at the moment, but one area I remember is that I think the names of indexes or tables will change slightly for MySQL in the process of introducing truncate_name(). This isn't a showstopper, but it means that sqlreset and friends break slightly across the merge point (because the newly generated names don't match the originals) so we should flag it. My memory says there was one other issue like that that we'd need to note. I'll finish reading through tonight or tomorrow and post my list. Nothing that would prevent a merge, though. It's all post-merge public-awareness stuff. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
