On Thu, 2008-07-03 at 02:06 -0700, Christian wrote:
[...]
> Should I send in patches for django.db.models.ModelBase,
> django.newforms.DeclarativeFieldsMetaclass, and
> django.newforms.MediaDefiningClass?

Sounds like a reasonable idea. Make patches against the right branches,
though, please. DeclarativeFieldsMetaclass and ModelBase should be
patched on trunk (and will then be absorbed into newforms-admin when
they next merge from trunk). MediaDefiningClass is a newforms-admin only
class, so that patch is directly for them.

Probably worth, therefore, having two tickets so that one is assigned to
version "SVN" and the other is version "newforms-admin".

Your analysis is correct, though. Calling super() is the right approach
(the fact that we do it in one place and then three lines later screw it
up is a little humiliating).

Malcolm



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to