Hi, I was going through the patch by carljm for #8630 [1] and decided to give it a try. I ran into troubles but not with the patch. The reason being comment templatetags reference 'is_public' [2] and 'is_removed' [3] fields of the Comment Model.
The idea for comments customization was to push essential fields onto BaseCommentAbstractModel and then inherit from this model. This would reduce the need to rewrite templatetags but I screwed this while sending patches just before the merge into trunk. I can think of two solutions to solve the problem. The first one being http://dpaste.com/82448/ and the second one (http://dpaste.com/82449/) to push the 'is_public' and 'is_removed' fields onto the BaseCommentAbstract Model. Both these changes are backward-compatible. I prefer the first method but would love to hear from you. I have opened a ticket for this at #9303 [4]. Please do post your thought either here or on this thread. [1] http://code.djangoproject.com/ticket/8630 [2] http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/templatetags/comments.py#L83 [3] http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/templatetags/comments.py#L86 [4] http://code.djangoproject.com/ticket/9303 PS: I have made quite a few mistakes and I am really sorry about them but if you believe I deserve to be spanked, please do ;-) -- Cheers Thejaswi Puthraya --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
