Hi list, Malcolm,
If I start working on a patch for #9664 (Transaction middleware closes the
transaction only when it's marked as dirty; marked for milestone 1.1), will I
be duplicating effort?
The solution I would propose is, essentially, a removal of the clean/dirty
concept from transactions; in the current django.db.transaction's terms,
considering all transactions dirty at all times. For all I can see, the only
purpose served by the dirty flag is preventing some open transactions from
closing properly, which is essentially the problem in the ticket.
However, I assume the dirty flag was put in originally to solve some problem,
perhaps a performance problem (I checked the svn history, and did some
searching of the django-developers group, and couldn't find any discussion of
this implementation detail); so I thought I should also ask first if anybody
remembers why it was put in.
(I realize that what I am proposing would be disastrous to anyone relying on
set_clean to delay the committing of a transaction; I checked, and the
function is not called anywhere in django itself, except for
django/db/transaction.py, but users might exist in user applications, so I
suggest to make this controllable from a setting, which would default to the
current behavior, but be set to "no clean/dirty" in the new-project
template).
So -- should I start working on the patch? Any other comments?
Thanks,
Shai.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
