On Thu, Mar 19, 2009 at 9:03 PM, James Bennett <ubernost...@gmail.com> wrote: > Too late now since it's already committed, but I've got some serious > reservations about this one. More development effort should have gone > into improving and refactoring the middleware before it got > automatically enabled.
Hmm, yeah... :-/ I've been traveling since Tuesday, and, shall we say, I'm not that excited about this being in the default middleware. In fact, I'm +1 for reverting this change and might even want to exercise the benevolent dictator veto on it, frankly. My reasoning: it's more overhead for every request, and it's a clunky implementation. I mean, parsing the HTML of every page with a regex? Come on. We ought to be making Django *faster*, not adding little pieces to it, bit by bit, until it gets bloated. And to raise a bit of bureaucracy in the process: there's something particularly Big And Important about changing anything in the global settings file -- whether it's adding a new setting, or changing a setting as fundamental as MIDDLEWARE_CLASSES -- so in the future I would ask that any such changes be given more discussion (and signoffs by committers) before a quick commit. In fact, it should be entirely opt-in, not opt-out. "Please let me know by Thursday evening (GMT) if there are objections" is not acceptable, IMO. Adrian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
