Johannes Dollinger wrote: > > Am 10.11.2009 um 17:22 schrieb Michael Glassford: > >> I haven't had a chance to look at the patch yet, but what you describe >> here sounds good. I don't have any problem with you "hijacking" the >> work. >> >> Did your patch deal at all with the unit tests in my patch that >> intentionally failed to expose things that weren't working right yet? > > Only the first of your patches contains tests.
Oops, right you are. The unit tests were unintentionally omitted. I've uploaded a new patch which is the pretty much the same as my previous patch but with my unit tests included (although comparing the two now I see a few other differences, probably because I also updated to the latest code in SVN). > But the ON DELETE > related tests in this patch that do not test database-level support > should be covered by my tests in modeltests/on_delete/. > Which of your tests failed? The tests that fail are in tests/modeltests/on_delete_django/tests.py. They have names like test_issue_1a, test_issue_1b, test_issue_2a, test_issue_2b, etc. The comments on the tests indicate the expected result. Once the issues they test for are fixed, they should all pass. Mike --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
