On Apr 30, 2010, at 10:56 AM, Russell Keith-Magee <freakboy3...@gmail.com
> wrote:
On Fri, Apr 30, 2010 at 11:11 PM, Jeremy Dunck <jdu...@gmail.com>
wrote:
As long as I'm here, how much interest is there in review board?
http://code.google.com/p/reviewboard/
...
5) The patch is missing some critical component like tests or docs
...
Cases 5 is annoying, particularly if it looks like the patch would be
in case 1 or 2 if only the contributor had written a test case. This
is a major time sink, but a code review tool isn't needed here - the
'needs tests' flag is all that is required.
I guess I didn't realize that commiters were writing tests and docs
for otherwise good patches. I assumed those just immediately got a
needs_* flag and sat until an interested party finished it.
Ideas how we can fix this?
--
You received this message because you are subscribed to the Google Groups "Django
developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
