On Fri, Jul 9, 2010 at 00:00, Russell Keith-Magee <russ...@keith-magee.com> wrote: > On Thu, Jul 8, 2010 at 3:55 PM, Lachlan Musicman <data...@gmail.com> wrote: >> Hola, >> >> I'm new to this dev thing, but I've done some work on ticket #5373
Another couple of hours of pdb'ing my way into this problem... > So - the next step is to make the tests more robust; you'll either > prove that this isn't a problem, or you'll find the edge case that > needs to be fixed. > As for the tests themselves; a general rule for testing is to test as > close to the source of the problem as possible. While I'm sure you > *can* observe this problem in the admin, the fact that the fix doesn't > involve any admin-specific code leads me to suspect that a better test > would be at a lower level -- in this case, testing that foreign key > fields return an appropriate verbose_name, and/or that ModelForms pick > up a translated verbose name. If you go to the ticket, you will see that I've added a new patch for django/db/models/fields/related.py This shows that the original change made in ticket 8011 (revision 8132) was not refactored properly. I have refactored 8011 so that it now does the same thing cleaner. Note that this does not solve the 5373 problem, merely proves that there is a problem. cheers L. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
