Hi all again! I've done some research on generic views integration and think that TemplateResponseMixin should be refactored in order to use TemplateResponse (SimpleTemplateResponse actually) because it currently assumes that template must be rendered before the response is returned.
'render_template' hook doesn't fit lazy-rendered responses and 'get_response' == 'render_to_response' if there is no 'render_template' hook. I propose to eliminate 'get_response' and 'render_template' hooks. These hooks are not used by django itself. get_response's purpose was to make it easy to override response class. Because render_to_response now returns response itself it is natural to override render_to_response instead of get_response. render_template's purpose was to change a way template is rendered. I don't know what is the exact use case. If one wants to use e.g. jinja2 template engine then he should override get_template method so it will return jinja.Template instead of django.Template (both have a 'render' method). Am I understand their purposes properly? Anyway, one can override render_to_response hook and return any HttpResponse subclass using any template rendering logic. Here is a chart to make things clear: http://www.lucidchart.com/publicSegments/view/4cc313b1-9478-4985-9870-2a190afcbe04 Some other gotchas: - TemplateResponseMixin.render_to_response should possibly be renamed to 'TemplateResponseMixin.render' for consistency. - django.test.TestCase.assertTemplateUsed should possibly bake the response explicitly because TemplateResponses are lazy. I need core developers' blessing. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
