On Tue, Jan 4, 2011 at 10:54 AM, Yo-Yo Ma <baxterstock...@gmail.com> wrote: [snip] > The difference in Django is that instantiation doesn't represent > "creation". Saving to the database does, and since the ORM is an > abstraction of the database, you don't care that the DB is ok with an > empty VARCHAR value. You only care about your model's required value. > I'm suggesting this: > > class Person(Model): > name = CharField(max_length=50) > > >>>> Person() # Should work fine (assign attributes later, etc) >>>> Person.objects.create() > ... Should raise some kind of exception before allowing your model's > "INTEGRITY" to be violated. >
No it shouldn't as no data validation has been run. Remember, like save(), create() does not run validation on the instance before writing to the db. As Russ pointed out, the actual data written to the db is valid as far as the db is concerned. Therefore, you get no errors. If you want to ensure the data is valid (as defined in your python code - not per the db) then you need to validate it in python *before* writing to the db. Therefore, don't use Person.objects.create()!!!! That being said, it does strike me as being a little odd that there is no way to validate your data when using create() or get_or_create(). In fact, the docs [1] describe both those methods as shortcuts. But if you're writing an app that always needs to validate your data, then you will never use those shortcuts which makes them rather useless. Of course, they existed long before (the current) model validation mechanism did, so I wonder if it would be reasonable to propose that they (at least optionally) be updated to run validation before saving. Or perhaps a warning in the docs that create() and get_or_create() do not run validation before writing to the db may be appropriate. [1]: http://docs.djangoproject.com/en/dev/ref/models/querysets/#create -- ---- \X/ /-\ `/ |_ /-\ |\| Waylan Limberg -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
